JavaScript closure issue on dynamic element creation in a loop -


during execution of page, string gets composed containing code need executed handler click event. string like:

var handler = '"myfunction1(12, 20);myotherfunction();"';

or

var handler = '"myfunction1(12, 20);"'

when create buttons dynamically, , try attach events in loop, gets attached last button only. can sense closure issue missing?

here code.

var buttons = [], arg1 = 12, arg2 = 20;  var butt1 = { text: 'bye', onclick: "anotherfunction();" }, butt = { text: 'hello', onclick: "mynewfunction();" }, butt2 = { text: 'bye333' };  buttons.push(butt1); buttons.push(butt); buttons.push(butt2);   function mynewfunction() {    alert('my new  function'); };  function myclosefunction(arg1, arg2) {     alert('close: ' + arg1 + ' other: ' + arg2) }  function anotherfunction() {     alert('say goodbye'); }   window.onload = function () {  var buttoncontainer = document.getelementbyid('controldiv'),     closeonclick = "myclosefunction(" + arg1 + ", " + arg2 + ")",     button;  (var = 0; < buttons.length; i++) {     buttons[i].onclick = (buttons[i].onclick == null) ? closeonclick : (closeonclick + ';\n' + buttons[i].onclick);     button = document.createelement("input");     button.type = 'button';     button.onclick = new function(buttons[i].onclick);      if (i > 0)         buttoncontainer.innerhtml += '&nbsp';     buttoncontainer.appendchild(button);    } };

the html page simple: 

<!doctype html>  <html lang="en"> <head>     <meta charset="utf-8" />     <title></title>     <script src="script.js" type="text/javascript"></script> </head> <body>     <h1>hello</h1>     <div id="controldiv"></div> </body> </html>

sensing closure issue have tried various options close on variables not successful. e.g.

button.onclick = (function (action, i) {     var name1 = 'hello' + i,         a123 = new function('action', 'return function ' + name1 + '(){action();}')(action);         return a123;     } (new function(buttons[i].onclick), i));

buttoncontainer.innerhtml += '&nbsp'; - line (or rather re-setting innerhtml) problem. don't think innerhtml property contains events. works expected here.


Comments

Post a Comment

Popular posts from this blog

php - cannot display multiple markers in google maps v3 from traceroute result -

i'm newbie in php mysql , google maps v3. have problems in google maps v3. made traceroute web based , map traceroute's result in google maps v3 final project of college education. have try many tutorials didn't work. have tried tutorials in forum nothing worked. problem cannot display multiple markers got location data database. maybe because i'm newbie , not know how do. confuse looping show markers. here code <?php error_reporting(e_all ^ (e_notice)); ini_set('max_execution_time', 360); $enable_log_user = false; global $ip, $host_name, $host_ip; $host = @$_post['host']; $trace = @$_post['trace']; $self = $_server['php_self']; include("phpsqlajax_dbinfo.php"); $connection = mysql_connect ('127.0.0.1', $username, $password); if (!$connection) { die('not connected : ' . mysql_error());} $db_selected = mysql_select_db($database, $connection); if (!$db_selected) { die ('can\'t use db : ...
Read more

c# - DetailsView in ASP.Net - How to add another column on the side/add a control in each row? -

i have detailsview control on page used edit various fields of record, works in respect. i looking way add 1 column (and if works, why not more) right, absolutely read-only, show same fields of record comparison purposes. i aware there no obvious way such thing out of box detailsview . have looked other controls (transposed gridview , recommended formview , listview ), nothing satisfies. have special data binding setup using detailsview , can't out of without losing features. anyone on how "hack in" additional columns (for display only) on detailsview ? the solution have now, use second detailsview , visible set false in aspx. in code, make sure databind hidden detailsview hosts data third column first, initial detailsview named itemdetails . and in item created event, pass third column html rendering of hidden controls (in last code block) : protected void itemdetails_itemcreated(object sender, eventargs e) { if (dataite...
Read more

javascript - firefox memory leak -

i have following script (i use raphaeljs also) draws circle, waits 1 second, draws circle again, etc (you can copy paste - functional, need include raphael raphaeljs.com): <div id="holder"> </div> <script src="raphael.js" type="text/javascript"></script> <script> var paper = raphael(10, 50, 320, 200); var rad = math.pi / 180; var finangle = 0; function sector(cx, cy, r, startangle, endangle, params) { var x1 = cx + r * math.cos(-startangle * rad), x2 = cx + r * math.cos(-endangle * rad), y1 = cy + r * math.sin(-startangle * rad), y2 = cy + r * math.sin(-endangle * rad); return ["m", cx, cy, "l", x1, y1, "a", r, r, 0, +(endangle - startangle > 180), 0, x2, y2]; } var path = sector(100,100,50,0,180); var arc = paper.path(path); function draw() { path = sector(100,100,50,0,finangle); ...
Read more